Skip to content

WINDUPRULE-266: new Seam API rules#255

Merged
jsight merged 3 commits into
windup:masterfrom
mareknovotny:WINDUPRULE-266
Aug 21, 2017
Merged

WINDUPRULE-266: new Seam API rules#255
jsight merged 3 commits into
windup:masterfrom
mareknovotny:WINDUPRULE-266

Conversation

@mareknovotny
Copy link
Copy Markdown
Contributor

@jsight
Copy link
Copy Markdown
Member

jsight commented Jul 27, 2017

I am a little bit concerned that the guidance for migration options is not really sufficient. If I understand it correctly, there is really a matrix of scenarios:

Seam Version EAP 6 EAP 7
Seam 2.2 Compatible but unsupported - requires switching to the JSF 1.x slot Not compatible. May be possible to get it working, but would require extensive changes that are not documented.
Seam 2.3 Compatible but unsupported Compatible but unsupported

I think that we should give the user all of these details in the rules that provide the user with a summary of their options. Please update the text if the guidance that I wrote above is incorrect, though.

@mareknovotny
Copy link
Copy Markdown
Contributor Author

The table matrix was not completely correct, see this:

Seam Version EAP 6 EAP 7
Seam 2.2 Compatible but unsupported - requires switching to the JSF 1.x and Hibernate 3 slots Not compatible. May be possible to get it working, but would require extensive changes that are not documented.
Seam 2.3 Compatible but unsupported and not tested on current EAP 6.x Not compatible

I thought that I give such guidance in Seam API classification , but if you think it is ambiguous or some unclarity, I can add the table matrix too. WDYT?

@jsight
Copy link
Copy Markdown
Member

jsight commented Jul 28, 2017

@mareknovotny - The problem with the description in the rule now is that it implies that they can continue to use Seam 2.x with EAP 7. At the time, I thought that might be possible and that is what Marc was demanding. I have since tried some apps and found that it was not as simple as just keeping it, and that seems to be what your updated table says as well.

I agree with your updates, with one caveat. It seems to me that Seam 2.3 did work on EAP 7 in the one (small) test with a quickstart that I did there. I'm sure there are some broken features, though, and obviously we have no documentation to say what works and what doesn't.

@mareknovotny
Copy link
Copy Markdown
Contributor Author

@jsight we can't be sure for every part of Seam on EAP7. It is not maintained and even java EE itself is backward compatible, there is no verification it works. That is what product can offer and as Seam is not supported product, nobody will say that loudly.

You can see here seam2/jboss-seam#29 what took to take Seam 2.3 from upstream to be able to run on Wildfly 10. Even Seam 2.3 from WFK had not jbpm integration it needed to upgrade some Java EE integrations and add new method for instance to not throw unexpected exceptions or stop to process in the middle.

I will add then clear message that EAP 7 doesn't support Seam in any version.

@jsight
Copy link
Copy Markdown
Member

jsight commented Jul 28, 2017

@mareknovotny - The same could be said for trying to run JSF 1.2 in it generally, but we tell them that it might work. ¯_(ツ)_/¯

Basically, it isn't recommended and if it breaks, they get to keep the pieces, but it would be consistent with the other "advice" that we have been required to make (regarding hibernate and JSF).

@mareknovotny
Copy link
Copy Markdown
Contributor Author

@jsight so what else in comparison to the latest commit we need to change/add here, I am a little unsure?

@jsight
Copy link
Copy Markdown
Member

jsight commented Aug 14, 2017

@mareknovotny - My only suggestion was to clarify the situation regarding Seam 2.3 on EAP 7, as it can be made to work under some circumstances. Basically this could be pretty similar to the guidance for Seam 2.3 on EAP 6, in that it can be made to work, but isn't recommended.

I can show you the app that I ported over to EAP 7 if you'd like? It was surprisingly easy, but of course it wasn't an extensive test (only a few pageflows and some basic templates).

I could not get JSF 1.2 to work at all and thus could not get anything from Seam 2.2 to work in EAP 7.

@jsight jsight merged commit b067b28 into windup:master Aug 21, 2017
@mareknovotny mareknovotny deleted the WINDUPRULE-266 branch August 23, 2017 07:45
jsight pushed a commit that referenced this pull request Sep 1, 2017
* WINDUPRULE-266: new Seam API rules

* WINDUPRULE-266 - clarifying EAP6/7 support in Seam API classification

* WINDUPRULE-266 clarify more Seam 2.3 on EAP7 classification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants